Add client remote address to some audit events#36354
Merged
gabrielcorado merged 7 commits intomasterfrom Jan 10, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
approved these changes
Jan 8, 2024
greedy52
approved these changes
Jan 8, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from lxea
….com:gravitational/teleport into gabrielcorado/add-client-info-admin-requests
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
gabrielcorado
deleted the
gabrielcorado/add-client-info-admin-requests
branch
|
@gabrielcorado See the table below for backport results.
|
gabrielcorado
added a commit
that referenced
this pull request
Jan 11, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Add client remote address to some audit events (#36354) * test(auth): update error assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #34598.
Adds client remote address to the following audit events:
user.create,user.update,user.delete, anduser.password_change.role.created,role.updated, androle.deleted.trusted_cluster.create,trusted_cluster.update, andtrusted_cluster.delete.github.created,github.updated, andgithub.deleted. And, also login events.To fetch the client's IP address, we rely on the same mechanism used for IP pinning, where the IP address is placed in the context.
changelog: Add client remote IP address to some administrative audit events (
user.create,user.update,user.delete,user.password_change,role.created,role.updated,role.deleted,trusted_cluster.create,trusted_cluster.update,trusted_cluster.delete,github.created,github.updated, andgithub.deleted).