Conversation
This field is set in `DocumentGatewayKube.tsx` when creating a gateway, but it wasn't explicitly defined on the type (it works because of loose types of `documentsService.update`).
gzdunek
added
the
no-changelog
gzdunek
requested review from
avatus
and removed request for
ibeckermayer and
kimlisa
gzdunek
force-pushed
the
gzdunek/unify-gateway-offline-screen
branch
from
a682d46 to
576da3b
Compare
|
I really like the bold name on its own above the rest of the text instead of inline. This looks great |
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Looks good! Though I think we shouldn't center the loading state.
| The database connection is {statusDescription} | ||
| {/* TODO(ravicious): Use doc.status instead of LinearProgress. */} | ||
| {props.connectAttempt.status === 'processing' && <LinearProgress />} | ||
| <Flex flexDirection="column" m="auto" alignItems="center" maxWidth="500px"> |
There was a problem hiding this comment.
I'm not sure if we should center it. We don't really have any other documents that do this, do we? When the app is almost fullscreen, especially on bigger screens, the transition from a centered loading state to a success state that's aligned to the top is going to look a bit weird.
There was a problem hiding this comment.
We have a very similar screen in DocumentCluster where we center the content.
But I think you are right, we should rather align it to the top. I changed it in both places.
Now it looks like below:
# Conflicts: # web/packages/teleterm/src/services/tshd/types.ts
3 participants
Currently, we have different loading and error screens for db and kube gateways. For example, the kube gateway uses document progress bar, while the db gateway uses inline progress. Also, kube gateway doesn't show any text when it is setting up.
Soon we will have another gateway type, so I wanted to have a single component that we could use there. I took an inspiration from the updated
DocumentClusterlook, which I think is quite nice.Before
Database gateway:
Kube gateway:
After
Database gateway:
Kube gateway:
