Fix incorrect audit log IP when using Kubernetes impersonation#36322
Merged
Fix incorrect audit log IP when using Kubernetes impersonation#36322
Conversation
Audit logs for Kubernetes requests showed incorrect IP addresses when reverse tunnel was used to forward the request. Audit logs use 'req.RemoteAddr` which was never updated with the impersonated IP address. Changelog: Fixed incorrect report of user's IP address in Kubernetes Audit Logs Fixes #36288 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
greedy52
approved these changes
Jan 5, 2024
gabrielcorado
approved these changes
Jan 5, 2024
AntonAM
approved these changes
Jan 5, 2024
zmb3
approved these changes
Jan 5, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
This was referenced Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit logs for Kubernetes requests showed incorrect IP addresses when reverse tunnel was used to forward the request.
Audit logs use 'req.RemoteAddr` which was never updated with the impersonated IP address.
Changelog: Fixed incorrect report of user's IP address in Kubernetes Audit Logs
Fixes #36288