[v14] Use GetRole in the user login state generator, fail if not found.#36321
Merged
mdwn merged 1 commit intobranch/v14from Jan 5, 2024
Merged
[v14] Use GetRole in the user login state generator, fail if not found.#36321mdwn merged 1 commit intobranch/v14from
mdwn merged 1 commit intobranch/v14from
Conversation
The user login state generator will use GetRole instead of GetRoles to lookup roles. GetRole has a more robust fallback when unable to find things in the cache, so using it directly will make the user login state generator more robust in general. Additionally, the user login state generator should not allow missing roles, so if a role is missing it will now throw an error.
mdwn
added
the
no-changelog
github-actions
Bot
requested review from
fspmarshall,
strideynet and
timothyb89
strideynet
approved these changes
Jan 5, 2024
fspmarshall
approved these changes
Jan 5, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36314 to branch/v14