Skip to content

Prevent deleting enum values in buf breaking #36248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
espadolini merged 2 commits into from
Jan 4, 2024
Merged

Prevent deleting enum values in buf breaking #36248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c18e1d
Prevent deleting enum values, allow deleting enum reservations in typ…
espadolini Dec 18, 2023
3edabc5
Merge branch 'master' into espadolini/buf-breaking-enum-delete
espadolini Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/proto/buf-legacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ lint:
- RPC_RESPONSE_STANDARD_NAME
breaking:
use:
- FILE
- "buf-legacy.yaml should not be used for buf breaking"
Copy link
Copy Markdown
Contributor

@codingllama codingllama Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creative.

4 changes: 4 additions & 0 deletions api/proto/buf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,7 @@ lint:
breaking:
use:
- WIRE_JSON
- ENUM_VALUE_NO_DELETE
ignore_only:
RESERVED_ENUM_NO_DELETE:
- teleport/legacy/types/types.proto
8 changes: 6 additions & 2 deletions proto/buf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: v1
deps:
# gogo/protobuf v1.3.2, keep in sync with build.assets/Makefile.
- buf.build/gogo/protobuf:b03c65ea87cdc3521ede29f62fe3ce239267c1bc
# gogo/protobuf v1.3.2, keep in sync with build.assets/Makefile.
- buf.build/gogo/protobuf:b03c65ea87cdc3521ede29f62fe3ce239267c1bc
lint:
use:
- DEFAULT
Expand Down Expand Up @@ -49,3 +49,7 @@ lint:
breaking:
use:
- WIRE_JSON
- ENUM_VALUE_NO_DELETE
ignore_only:
RESERVED_ENUM_NO_DELETE:
- teleport/legacy/types/types.proto