Fix user invites preventing tokens list#36048
Merged
gabrielcorado merged 1 commit intomasterfrom Jan 9, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
gabrielcorado
added
the
no-changelog
espadolini
approved these changes
Jan 2, 2024
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
Why is trusted_cluster special cased, anyway?
Contributor
|
BTW I think that mentioning that a bug got fixed is changelog-worthy. |
ibeckermayer
approved these changes
Jan 5, 2024
gabrielcorado
removed
the
no-changelog
Contributor
Author
I'm not 100% sure about this, but upon examining the code, it appears its purpose is to rename |
|
@gabrielcorado See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34387.
changelog: Fix user invites preventing listing tokens.
When initializing
types.SystemRolesfrom a specification, the initializer converts the roles into strings usingStringSlice, which utilizes theStringmethod fromtypes.SystemRole. However, theRoleSignupfunction may return a value that is not present in the system role mappings, causing a validation failure as shown in the issue.Alternatively, we could add "password" to the
roleMappingso that roles with this name would be correctly matched, and the returned value ontctl get tokenwould still bePassword.