Web: Support auto discovery for self-hosted#36027
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
kimlisa
added
the
no-changelog
kimlisa
force-pushed
the
lisa/rds-auto-discover-self-hosted
branch
from
3005447 to
d58c6d6
Compare
| const discoveryGroupToolTip = `Discovery group name is used to group discovered resources into different sets. \ | ||
| This parameter is used to prevent Discovery Agents watching different sets of cloud resources from \ | ||
| colliding against each other and deleting resources created by another services.`; | ||
|
|
There was a problem hiding this comment.
This reads a little weird. But tbh, i haven't used this in production so idk. what are the different "sets", is that the technical term or is there a better word we can use here. Also, "parameter" doesn't really seem UX friendly. Maybe "value" or something but idk, I won't die on that hill.
I don't recommend my suggestion 100%, but here are my thoughts.
"Discovery Group Name (i know its not all capital but maybe it'll help differentiate it as the term) is used to name a group of discovered resources. This group name is used to prevent deleting resources created by other services being watched by different Discovery Agents"
could fiddle with it idk
There was a problem hiding this comment.
i copied this directly from the docs, so i'm hesitant to change it since the texting at least was reviewed by the doc folks: https://docs-2dew2l61w-goteleport.vercel.app/docs/database-access/guides/aws-discovery/#step-24-configure-the-discovery-service
|
updated screenshot after moving the relevant docs into the web UI: 
|
kimlisa
force-pushed
the
lisa/rds-auto-discover-self-hosted
branch
from
809fe56 to
1bf98f2
Compare
* Web: Support auto discovery for self-hosted * Move doc instructions into web UI * fix test
…) (#36434) * Web: Add auto enrolling capabilities to RDS discover flow (#35646) * Add discovery config endpoint * Add autoDiscoveryConfig field to meta * Hide custom label for auto discover * Pull out re-usable parts for storybook fixture * Only allow adding new traits when auto-enrolling - Existing traits is not made editable - Minor refactor: pull data from useDiscover context * Auto select integration if only one result * Skip test connection when auto enrolling Refactor setup access story * Add auto enroll toggler * Create finish component for auto discover * Add more disabled row states * Add clarifying notes * Address CRs * Finish auto discovery - When enrolling and opting for auto discovery, we need to first collect all missing vpcs to determine if its required to deploy database agents, and then create a discovery config for a discovery service - When auto deploying and opting for auto discovery, it is out scope for this iteration to allow user to define custom labels, select security groups, and "wait" for deploying all services to finish. Instead after deploy request is finished, we render a box that tells user it will take a minute to finish deploying and give a AWS dashboard link to view progress - Setup access screen is the final step (skip test connection) and we render how to setup access for both mysql and postgres since auto discovery discovers all supported engine types. * Address CR * Update straggling test * Web: Support auto discovery for self-hosted (#36027) * Web: Support auto discovery for self-hosted * Move doc instructions into web UI * fix test
3 participants
resolves #35434
Adds support for auto discovery for self-hosted.
Self-hosted requires users to run their own discovery service (unlike cloud where every tenant has one running already whether they use it or not). This required some extra instructions for the user to help them run a discovery service.
The only difference in terms of web UI logic, is that user supplies us their own
discovery group name(for cloud this is a hardcoded value), everything else is the same as cloud.story: http://127.0.0.1:9002/?path=/story/teleport-discover-database-enrollrds--instance-list