Fix most of the warnings related to act#35926
Merged
Conversation
gzdunek
added
the
no-changelog
zmb3
approved these changes
Dec 20, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
kimlisa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading React to v18, there was a lot of errors related to
act. They were caused by an incorrect version of@testing-library/domthat was resolved.To fix this, I updated
eslint-plugin-jest-dom. Starting from version v5,@testing-library/domis a peer dependency there.Related issue: #34286 (comment)
Previously we had 346 warnings, now we have 19: