integrations/updater: add nop validator#35896
Merged
Conversation
marcoandredinis
approved these changes
Dec 20, 2023
tigrato
approved these changes
Dec 20, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from r0mant
Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
|
@hugoShaka See the table below for backport results.
|
This was referenced Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: add the
--insecure-no-resolve-imageflag to theteleport-kube-agent-udpaterto disable image tag resolution if it cannot pull the image.I added a new validator instead of modifying the existing
insecureone because not resolving images provides worse availability guarantees than resolving but not validating: when resolving, the updater checks if the image exists. Disabling resolution can lead the updater to create pods with non-existing images as it has no visibility in the registry.This PR unblocks this customer Slack thread (internal link): https://goteleport.slack.com/archives/C0582MBSMHN/p1702904519028439?thread_ts=1702663524.742029&cid=C0582MBSMHN