Set PIV build tag on Windows native builds#35863
Merged
Conversation
ibeckermayer
approved these changes
Dec 18, 2023
r0mant
approved these changes
Dec 18, 2023
public-teleport-github-review-bot
Bot
removed request for
Joerger and
fspmarshall
|
@fheinecke See the table below for backport results.
|
This was referenced Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last few releases have broken PIV support on Windows as the PIV tag was not set. This PR fixes the issue, and fixes the long-running issue of PIV not being supported by the version of TSH included with Teleport Connect.
Note that linking with libpcsclite as suggested in the linked issue is not required on Windows: https://github.com/go-piv/piv-go/blob/66ce787eec2b47673aebac019f248a3552d9783e/README.md?plain=1#L257-L262
Changelog: Fixed PIV not being available on Windows TSH binaries
Closes #35787