[v14] Stop users from deleting their last passwordless device#35855
Merged
codingllama merged 2 commits intobranch/v14from Dec 18, 2023
Merged
[v14] Stop users from deleting their last passwordless device#35855codingllama merged 2 commits intobranch/v14from
codingllama merged 2 commits intobranch/v14from
Conversation
github-actions
Bot
requested review from
kimlisa,
marcoandredinis and
rosstimothy
Contributor
Author
|
Production code ported cleanly, but tests are missing various refactors I did when deprecating MFA streams - see #20343 (comment). There are a few tweaks on things like client names (no I also found out that the WithPasswordless() test option wasn't working, so fixed that one too. |
This was referenced Dec 18, 2023
marcoandredinis
approved these changes
Dec 18, 2023
kimlisa
approved these changes
Dec 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35794 to branch/v14.
Stop users from deleting their last passwordless device in a passwordless-capable cluster.
In certain situations, like clusters with "second_factor:optional", it's possible to delete all your MFA devices. A pure passwordless user could lock themselves out by doing so.
This PR makes it impossible to delete your last passwordless device (if the cluster allows passwordless logins), preventing those lockouts at the cost of being more restrictive for "normal" users.
#32690
Changelog: Stop users from deleting their last passwordless device