Skip to content

AccessLists: pick a next audit date if not specified#35795

Merged
hugoShaka merged 3 commits intomasterfrom
hugo/default-al-creation
Dec 18, 2023
Merged

AccessLists: pick a next audit date if not specified#35795
hugoShaka merged 3 commits intomasterfrom
hugo/default-al-creation

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

changelog: new AccessLists with unspecified NextAuditDate now pick a new date instead of being rejected

This change allows clients like the operator or the TF to create ALs and let Teleport figure out when the next audit is.

@hugoShaka hugoShaka force-pushed the hugo/default-al-creation branch from 51da2bd to 25eeba6 Compare December 15, 2023 19:56
@hugoShaka hugoShaka marked this pull request as ready for review December 15, 2023 20:04
@github-actions github-actions Bot requested review from atburke and kimlisa December 15, 2023 20:05
Copy link
Copy Markdown
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for @mdwn review. I remember that this code has a lot of corner cases that I may not be aware of.

@hugoShaka hugoShaka added this pull request to the merge queue Dec 18, 2023
Merged via the queue into master with commit d6eac6f Dec 18, 2023
@hugoShaka hugoShaka deleted the hugo/default-al-creation branch December 18, 2023 15:10
@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka See the table below for backport results.

Branch Result
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants