charts/kube-agent: updater extraArgs#35786
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
🤖 Vercel preview here: https://docs-8pvllf8o1-goteleport.vercel.app/docs/ver/preview |
marcoandredinis
approved these changes
Dec 15, 2023
ptgott
approved these changes
Dec 15, 2023
tigrato
reviewed
Dec 15, 2023
| - "--version-server={{ tpl $updater.versionServer . }}" | ||
| - "--version-channel={{ $updater.releaseChannel }}" | ||
| {{- if .Values.updater.extraArgs }} | ||
| {{- toYaml .Values.updater.extraArgs | nindent 10 }} |
Contributor
There was a problem hiding this comment.
can we add a snapshot to ensure the indentation is always ok?
I am now paranoid about that
Contributor
Author
There was a problem hiding this comment.
If indentation is not OK the contains test will properly fail as the item won't be in the list. The issue earlier was caused by the fact we did 2 rounds of dumping yaml/parsing yaml because of the config merge hack.
tigrato
approved these changes
Dec 15, 2023
public-teleport-github-review-bot
Bot
removed request for
r0mant,
webvictim,
xinding33 and
zmb3
|
@hugoShaka See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass extra args to the updater. This can be used to disable image validation, but I don't want to use this example in the user docs to reduce the number of users relying on this flag.
changelog: the
teleport-kube-agentchart supports passing extra arguments to the updater.