fix agent config templating when using appResource and discovery#35781
Merged
fix agent config templating when using appResource and discovery#35781
Conversation
hugoShaka
requested review from
AntonAM,
marcoandredinis,
tigrato and
webvictim
tigrato
reviewed
Dec 15, 2023
| uri: https://console.aws.amazon.com/ec2/v2/home | ||
| labels: | ||
| env: test | ||
| appResources: |
Contributor
There was a problem hiding this comment.
can you add a test case for this file to ensure all fields are filled ?
Contributor
Author
There was a problem hiding this comment.
It's a bit hard because the config is not rendered directly but in a string in a configmap key, we can't use assert.sets. Best I can do is a snapshot.
tigrato
approved these changes
Dec 15, 2023
marcoandredinis
approved these changes
Dec 15, 2023
public-teleport-github-review-bot
Bot
removed request for
AntonAM and
webvictim
AntonAM
approved these changes
Dec 15, 2023
webvictim
approved these changes
Dec 15, 2023
|
@hugoShaka See the table below for backport results.
|
hugoShaka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: fix a bug in
teleport-kube-agentchart when using bothappResourcesand thediscoveryrole.The bug was caused by a mismatched indentation between the
.Values.appResources | toYamland the items added whenDiscoverywas on. I also updated all thenindent Xto make more sense.