Conversation
- use pkg path when working with URL-based paths (not file paths) - fix computation of audit session URL (which was mising the tenant prefix) - fix test compilation error that went unnoticed due to the test only running behind the dynamodb build tag
github-actions
Bot
added
audit-log
rosstimothy
approved these changes
Dec 14, 2023
camscale
approved these changes
Dec 15, 2023
Contributor
camscale
left a comment
camscale
left a comment
There was a problem hiding this comment.
LGTM. Having just revised a bunch of changelogs, I've cleaned up the "fix an issue where..." language to be a bit more direct. How about:
changelog: Fixed session upload audit event sometimes containing an incorrect URL for the session recording.
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
This was referenced Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Fixed session upload audit event sometimes containing an incorrect URL for the session recording.