[v14] Return the correct errors to users when an mfa ceremony fails#35750
Merged
rosstimothy merged 1 commit intobranch/v14from Dec 19, 2023
Merged
[v14] Return the correct errors to users when an mfa ceremony fails#35750rosstimothy merged 1 commit intobranch/v14from
rosstimothy merged 1 commit intobranch/v14from
Conversation
Errors returned from the mfa prompt are now wrapped to allow them to be differentiated and acted upon accordingly by callers. No further processing of the error is required in this change, the code that examines the errors will already do the right thing. Fixes #35580.
rosstimothy
force-pushed
the
tross/backport-35581/v14
branch
from
ad71434 to
ebbe2d5
Compare
github-actions
Bot
added
size/sm
tsh
github-actions
Bot
requested review from
GavinFrazar,
flyinghermit and
smallinsky
flyinghermit
approved these changes
Dec 15, 2023
GavinFrazar
approved these changes
Dec 15, 2023
smallinsky
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35581 to branch/v14
changelog: Prevent tsh from re-authenticating if the mfa ceremony fails during tsh ssh