[v14] Always reply to x-teleport-terminal-size if requested#35743
Merged
rosstimothy merged 1 commit intobranch/v14from Dec 19, 2023
Merged
[v14] Always reply to x-teleport-terminal-size if requested#35743rosstimothy merged 1 commit intobranch/v14from
rosstimothy merged 1 commit intobranch/v14from
Conversation
The ssh handlers were only replying to the request in the happy path and never if something went wrong. This causes our clients to hang indefinitely waiting since they are reliant on the response to determine the correct terminal size when joining an existing session.
marcoandredinis
approved these changes
Dec 14, 2023
Contributor
Author
|
PTAL @zmb3 |
zmb3
approved these changes
Dec 19, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35703 to branch/v14
changelog: Prevent attempts to join a nonexistent ssh session from hanging forever