[v14] Backport changes done to shared/UnifiedResources when adding resource pinning to Connect#35690
Merged
gzdunek merged 1 commit intobranch/v14from Dec 14, 2023
Merged
Conversation
…ce pinning to Connect * Add `unifiedResourcesPreferencesAttempt` to `UnifiedResources` * Show skeleton when `unifiedResourcePreferencesAttempt` is processing * Do not show 'pinning not supported' and 'no results' errors at the same time * Check for `''` too when calculating `isProcessing` * Remove `width` from expand/collapse button, so it looks good independently of font weight
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
gzdunek
added
no-changelog
zmb3
approved these changes
Dec 13, 2023
avatus
approved these changes
Dec 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ravicious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the change to the shared part in #35251
Add
unifiedResourcesPreferencesAttempttoUnifiedResourcesShow skeleton when
unifiedResourcePreferencesAttemptis processingDo not show 'pinning not supported' and 'no results' errors at the same time
Check for
''too when calculatingisProcessingRemove
widthfrom expand/collapse button, so it looks good independently of font weight