Skip to content

Add latency diagnostic to tsh#35679

Merged
rosstimothy merged 1 commit intomasterfrom
tross/tsh_ssh_latency
Dec 19, 2023
Merged

Add latency diagnostic to tsh#35679
rosstimothy merged 1 commit intomasterfrom
tross/tsh_ssh_latency

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy commented Dec 12, 2023

The new tsh latency command allows visualizing latency to resources in real time. Currently, supported is limited to SSH instances, but may be extended to anything that implements a latency.Pinger to support other protocols in the future.

Changelog: Add tsh latency command to monitor ssh connection latency in realtime

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Dec 12, 2023
@rosstimothy rosstimothy force-pushed the tross/tsh_ssh_latency branch 2 times, most recently from 5115685 to 148250b Compare December 14, 2023 18:26
@rosstimothy
Copy link
Copy Markdown
Contributor Author

Example usage from running tsh latency ssh ubuntu@node

Screenshot 2023-12-14 at 1 20 31 PM

@rosstimothy rosstimothy force-pushed the tross/tsh_ssh_latency branch 3 times, most recently from babd453 to 379a23c Compare December 14, 2023 20:39
@rosstimothy rosstimothy marked this pull request as ready for review December 14, 2023 20:52
@github-actions github-actions Bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Dec 14, 2023
@rosstimothy
Copy link
Copy Markdown
Contributor Author

Friendly ping @tigrato @fheinecke

Comment thread tool/tsh/common/latency.go Outdated
Comment thread tool/tsh/common/latency.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to error here? Can we just make it work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new `tsh latency` command allows visualizing latency to
resources in real time. Currently, supported is limited to SSH
instances, but may be extended to anything that implements a
`latency.Pinger` to support other protocols in the future.
@rosstimothy rosstimothy force-pushed the tross/tsh_ssh_latency branch from 0abbb22 to 1b27f28 Compare December 19, 2023 20:37
@rosstimothy rosstimothy added this pull request to the merge queue Dec 19, 2023
Merged via the queue into master with commit 9be0b67 Dec 19, 2023
@rosstimothy rosstimothy deleted the tross/tsh_ssh_latency branch December 19, 2023 21:13
@public-teleport-github-review-bot
Copy link
Copy Markdown

@rosstimothy See the table below for backport results.

Branch Result
branch/v14 Failed

rosstimothy added a commit that referenced this pull request Dec 19, 2023
The new `tsh latency` command allows visualizing latency to
resources in real time. Currently, supported is limited to SSH
instances, but may be extended to anything that implements a
`latency.Pinger` to support other protocols in the future.
@rosstimothy rosstimothy removed the no-changelog Indicates that a PR does not require a changelog entry label Dec 19, 2023
github-merge-queue Bot pushed a commit that referenced this pull request Dec 20, 2023
The new `tsh latency` command allows visualizing latency to
resources in real time. Currently, supported is limited to SSH
instances, but may be extended to anything that implements a
`latency.Pinger` to support other protocols in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants