Rework proxyline parsing for SSH direct dial nodes#35659
Closed
espadolini wants to merge 1 commit intomasterfrom
Closed
Rework proxyline parsing for SSH direct dial nodes#35659espadolini wants to merge 1 commit intomasterfrom
espadolini wants to merge 1 commit intomasterfrom
Conversation
espadolini
force-pushed
the
espadolini/proxyline-inline
branch
3 times, most recently
from
6d6cbb1 to
bf667ee
Compare
espadolini
force-pushed
the
espadolini/proxyline-inline
branch
from
3c8a6d7 to
6e7251a
Compare
espadolini
force-pushed
the
espadolini/proxyline-inline
branch
from
6e7251a to
bab9de2
Compare
Contributor
Author
|
Closing this in favor of #35762 because our test code relies far too much on the exact semantics of the multiplexer server - I intend to revisit that in the future, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the SSH service listener (in direct dial mode) to use a dedicated connection handler to parse the optional signed PROXY protocol v2 header from the proxy (instead of relying on the generic protocol multiplexer), with the ability to send "early data" such as the SSH version identification string.
Fixes #35647.
Changelog: Restored direct dial SSH server compatibility with certain SSH tools (such as
ssh-keyscan).