Add insecure-drop to host creation docs#35586
Merged
Conversation
atburke
added
backport/branch/v12
no-changelog
github-actions
Bot
requested review from
Joerger,
ptgott,
r0mant,
rosstimothy,
xinding33 and
zmb3
5 tasks
Contributor
|
🤖 Vercel preview here: https://docs-5s299dzsv-goteleport.vercel.app/docs/ver/preview |
ptgott
reviewed
Dec 11, 2023
Comment on lines
+33
to
+34
| - `drop` will create transient users that are deleted once the session ends. | ||
| - `insecure-drop` is the same as `drop` except it does not create a home directory for the user. |
Contributor
There was a problem hiding this comment.
I think we should add a sentence to the drop and insecure-drop descriptions to indicate why you would want to use either option.
With insecure-drop, the naming suggests that there are some tradeoffs between security and convenience at work, but I don't know if we can count on the user being able to discern these from the current descriptions (Maybe it's my particular background, but I know I can't).
Contributor
|
🤖 Vercel preview here: https://docs-jgsxv0ql0-goteleport.vercel.app/docs/ver/preview |
ptgott
approved these changes
Dec 11, 2023
Joerger
approved these changes
Dec 14, 2023
public-teleport-github-review-bot
Bot
removed request for
r0mant,
rosstimothy,
xinding33 and
zmb3
This was referenced Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds documentation for the
insecure-drophost user creation mode added in #35175.Part of #34340.