SAML IdP attribute mapping types and config handler#35584
Merged
flyinghermit merged 11 commits intomasterfrom Dec 14, 2023
Merged
SAML IdP attribute mapping types and config handler#35584flyinghermit merged 11 commits intomasterfrom
flyinghermit merged 11 commits intomasterfrom
Conversation
…/attribute-mapping-types
- Check for duplciate attribute names
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
flyinghermit
commented
Dec 12, 2023
Contributor
Author
|
Friendly ping |
r0mant
reviewed
Dec 14, 2023
Collaborator
r0mant
left a comment
There was a problem hiding this comment.
A few stylistic nitpicks.
- use map instead of slice for finding duplicate names
Contributor
Author
|
Friendly ping @xacrimon @fspmarshall @mdwn |
r0mant
approved these changes
Dec 14, 2023
mdwn
approved these changes
Dec 14, 2023
…/attribute-mapping-types
|
@flyinghermit See the table below for backport results.
|
flyinghermit
added a commit
that referenced
this pull request
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports attribute mapping configuration in
saml_idp_service_providerspec.value of
name_formatcan be one of the following:urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified. Used as a default value.urn:oasis:names:tc:SAML:2.0:attrname-format:uri.urn:oasis:names:tc:SAML:2.0:attrname-format:basic.Reference spec file:
RFD: https://github.com/gravitational/teleport.e/pull/2801
see #34725, https://github.com/gravitational/teleport.e/issues/2692
changelog: attribute mapping in
saml_idp_service_providerspec.