Add database roles to tsh db ls -v

[greedy52]

Pre-req to

• Ability to select database roles for auto-user-provisioning database session #35566

changelog: Added "Database Roles" column to tsh db ls -v

Changes:

• Added "Database Roles" column to tsh db ls -v
• Added database_roles to tsh db ls -f json/yaml
• Fixed an issue tsh db ls -R returns missing "Expires" column

Did some minor refactoring. Might be easier to review each commit separately.

Usage example:

$ tsh db ls -v --search mongo-auto
Name                   Description Protocol Type        URI             Allowed Users              Database Roles                                  Labels                                                   Connect 
---------------------- ----------- -------- ----------- --------------- -------------------------- ----------------------------------------------- -------------------------------------------------------- ------- 
self-hosted-mongo-auto             mongodb  self-hosted localhost:27017 [STeve] (Auto-provisioned) [my-custom-role@test read@test2 readWrite@test] EnableMongoAutoUser=true,teleport.dev/origin=config-file     

$ tsh db ls --search mongo-auto -f json | jq .[].database_roles
[
  "my-custom-role@test",
  "read@test2",
  "readWrite@test"
]

[GavinFrazar]

how about an option -C,--columns=column,... to include columns? Usually easier to think about what columns you want than what columns you don't want imo.

Definitely a good idea to allow column filtering though! My first thought on seeing the PR title was how cluttered tsh db ls output is getting lol

[Tener]

It would be nice to support comma-separated list in -E, too.

[zmb3]

tsh db ls is not the only place where we are using columnar output in ways that become unreadable.

This is another one of the things I'd love to get in a CLI style guide (see #12811).

I think we should do some form of an output format that can apply to anything.

Kubectl supports a few too many options (IMO), but there's surely some inspiration we can take from them:

• Custom columns: https://kubernetes.io/docs/reference/kubectl/#custom-columns
• JSONPath: https://kubernetes.io/docs/reference/kubectl/jsonpath
• or even Go template expressions

[greedy52]

tsh db ls is not the only place where we are using columnar output in ways that become unreadable.

This is another one of the things I'd love to get in a CLI style guide (see #12811).

I think we should do some form of an output format that can apply to anything.

Kubectl supports a few too many options (IMO), but there's surely some inspiration we can take from them:

• Custom columns: https://kubernetes.io/docs/reference/kubectl/#custom-columns
• JSONPath: https://kubernetes.io/docs/reference/kubectl/jsonpath
• or even Go template expressions

I will remove the --exclude-column from this PR for now. I'd love to join the discussion on these for the CLI style guide.

Docker also uses Go template:
https://docs.docker.com/config/formatting/

$ docker image list --format "table {{.ID}}\t{{.Repository}}\t{{.Tag}}\t{{.Size}}"
$ docker ps --format "table {{.Names}}\t{{.Ports}}"

[Tener]

Kubectl supports a few too many options (IMO), but there's surely some inspiration we can take from them:

• Custom columns: https://kubernetes.io/docs/reference/kubectl/#custom-columns
• JSONPath: https://kubernetes.io/docs/reference/kubectl/jsonpath
• or even Go template expressions

I don't think we need this level of flexibility, but some customisation would be nice. Perhaps we can add generic config to asciitable.Table, read and populated by tsh and tctl?

"tsh db ls":
     columns: Proxy Name Protocol Description Type AllowedUsers     

Each call to asciitable.MakeTable would take an additional argument, "context", which would be the name of the operation that displays the table, tsh db ls in the example above.

[public-teleport-github-review-bot]

@greedy52 See the table below for backport results.

Branch	Result
branch/v14	Failed