User login state generator copies user labels.#35487
Merged
strideynet merged 2 commits intomasterfrom Dec 7, 2023
Merged
Conversation
The user login state generator will now copy the user labels to the user login state. This simplifies a few things in our bot functionality, so unneeded bits have been removed as a result.
strideynet
approved these changes
Dec 7, 2023
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Tested this locally and fixes the issue 👍
Contributor
|
Closes #35443 |
Tener
approved these changes
Dec 7, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
This was referenced Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user login state generator will now copy the user labels to the user login state. This simplifies a few things in our bot functionality, so unneeded bits have been removed as a result.
Closes #35443
changelog: Fix bot's unable to view or approve access requests due to ULS overwriting.
Note: This should be verified by @strideynet before being committed.