[v13] Fix panic on nil value in getPresetRoles()#35462
Merged
timothyb89 merged 6 commits intobranch/v13from Dec 8, 2023
Merged
[v13] Fix panic on nil value in getPresetRoles()#35462timothyb89 merged 6 commits intobranch/v13from
getPresetRoles()#35462timothyb89 merged 6 commits intobranch/v13from
Conversation
This fixes a panic when attempting to fetch `/webapi/presetroles` as `ui.NewRoles()` is (reasonably) not nil safe. `GetPresetRoles()` can return nil entries if corresponding features are disabled, so this tweaks `GetPresetRoles()` to filter out nil entries. This endpoint is only used for Cloud features (email invites at onboarding, specifically) and currently all features are enabled for Cloud users, so the only internal use is minimally impacted. The other use of `GetPresetRoles()`, `createPresetRoles()`, already checks for nil entries. It's behavior is unchanged.
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
zmb3
approved these changes
Dec 7, 2023
mdwn
approved these changes
Dec 7, 2023
Not all CI jobs seem to run on the go version that added `slices`, so this unrolls the implementation for v13. v14 and master both use the `slices` impl.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35458 to branch/v13
changelog: Fixed panic on potential nil value when requesting
/webapi/presetroles