Conversation
|
When I tested this out the browser opens to a page which shows |
The setup needed for it to work is kind of specific. What flags did you pass to |
I think when I originally tested this flow that the callback was being served by my local Teleport Proxy. I tried again with nothing listening locally on port 443 with |
5c4124e to
7c72e40
Compare
jentfoo
left a comment
There was a problem hiding this comment.
I am a little concerned about this change. I believe it's possible to safely introduce this feature, but right now customers could use it without realizing the security implications. I also think the enforcement of an https schema is important.
Please let me know your thoughts, thank you!
jentfoo
left a comment
There was a problem hiding this comment.
Thank you for adding the most recent changes. Given the direct prompt and schema enforcement I feel users can reasonably understand the risks of this feature.
e80ee00 to
c96ed0b
Compare
|
Friendly ping @rosstimothy |
This change adds the --callback flag to tsh login, which overrides the base URL printed when doing an SSO login.
c96ed0b to
6267d9d
Compare
|
Documentation is missing for this: #43373 |
This change adds the
--callbackflag totsh login, which overrides the base URL printed when doing an SSO login. This allows thetshSSO login flow to be completed on a remote host (as long as the host runningtshis accessible over HTTPS with the given callback url).Resolves gravitational/customer-sensitive-requests#135.
Changelog: Added --callback flag to tsh login