Conversation
AntonAM
force-pushed
the
anton/fix-idp-initiated-sso-ip-propagation
branch
from
1cf912d to
3c9dba3
Compare
avatus
approved these changes
Dec 6, 2023
lxea
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a problem with correct client IP propagation during IdP initiated SSO flow. When Proxy received API call it then called Auth server's
ValidateSAMLResponse()using it's own auth client, so IP that was linked to that request ended up being Proxy's instead of client's. This PR modifiesValidateSAMLResponse()call so Proxy can send real client IP to the Auth server, which will be used for IdP initiated SSO case.This PR has a sibling in enterprise repo ( https://github.com/gravitational/teleport.e/pull/2841 ), they should be reviewed together.
Changelog: Fix client IP propagation from the Proxy to the Auth during IdP initiated SSO
Fixes #35318