Skip to content

Add initial future assume role to access requests#35257

Merged
EdwardDowling merged 12 commits intomasterfrom
edwarddowling/future-assume-roles
Dec 14, 2023
Merged

Add initial future assume role to access requests#35257
EdwardDowling merged 12 commits intomasterfrom
edwarddowling/future-assume-roles

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Dec 1, 2023

Add future assume time to access requests.

Adds assume-time field to access requests.
Adds --assume-time to tsh create and tsh approve. Adds "Assume Time" column to tsh request ls

Part of #13277

changelog: Add future assume time to access requests

@EdwardDowling EdwardDowling marked this pull request as ready for review December 1, 2023 16:45
@github-actions github-actions Bot requested review from avatus and greedy52 December 1, 2023 16:45
@github-actions github-actions Bot added size/md tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Dec 1, 2023
Comment thread lib/auth/auth.go Outdated
Copy link
Copy Markdown
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have precedence of using RFC3339 as a format in other cli arguments?

Comment thread api/proto/teleport/legacy/client/proto/authservice.proto Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
Comment thread tool/tsh/common/access_request.go Outdated
@EdwardDowling
Copy link
Copy Markdown
Contributor Author

EdwardDowling commented Dec 6, 2023

Do we have precedence of using RFC3339 as a format in other cli arguments?

From what I could find it seems to be the most commonly used format in /tool for parsing times.
After a search for time.parse, this format seems to be used for the tctl's 'acl', 'bot' and 'lock', command's 'expires' flags

./tctl/common/lock_command.go111:		t, err := time.Parse(time.RFC3339, expires)
./tctl/common/acl_command.go145:		expires, err = time.Parse(time.RFC3339, c.expires)
./tctl/common/devices.go378:		t, err := time.Parse(time.RFC3339, c.expires)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 8, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@EdwardDowling
Copy link
Copy Markdown
Contributor Author

@greedy52 @avatus Just fixed the serialization test and added the checks to stop assum_start_times too far in future since you reviewed. Is this still good to go?

@r0mant r0mant requested a review from smallinsky December 11, 2023 16:39
@EdwardDowling EdwardDowling force-pushed the edwarddowling/future-assume-roles branch from 0a67317 to 92322a6 Compare December 13, 2023 17:18
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from smallinsky December 13, 2023 17:19
Comment thread api/constants/constants.go Outdated
Comment thread lib/auth/auth.go Outdated
Comment thread lib/auth/auth.go Outdated
@EdwardDowling EdwardDowling added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit 451d3de Dec 14, 2023
@EdwardDowling EdwardDowling deleted the edwarddowling/future-assume-roles branch December 14, 2023 16:51
@public-teleport-github-review-bot
Copy link
Copy Markdown

@EdwardDowling See the table below for backport results.

Branch Result
branch/v14 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/md tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants