[v14] Correctly clone RoleV6 when downgrading#35236
Merged
r0mant merged 4 commits intobranch/v14from Nov 30, 2023
Merged
Conversation
Fix panic caused by improper clone of `RoleV6` when downgrading. This PR forces a clone before downgrading it. Fixes #35229 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
Bot
requested review from
hugoShaka,
jakule,
r0mant,
tigrato and
zmb3
r0mant
approved these changes
Nov 30, 2023
tigrato
approved these changes
Nov 30, 2023
public-teleport-github-review-bot
Bot
removed request for
hugoShaka,
jakule and
zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35230 to branch/v14
Changelog: Fixed a possible panic when downgrading Teleport Roles to older versions.