Machine ID: Add Protos for Bot Resource and CRUD RPCs#35216
Merged
strideynet merged 7 commits intomasterfrom Dec 6, 2023
Merged
Machine ID: Add Protos for Bot Resource and CRUD RPCs#35216strideynet merged 7 commits intomasterfrom
strideynet merged 7 commits intomasterfrom
Conversation
strideynet
commented
Dec 1, 2023
strideynet
added
the
no-changelog
nklaassen
approved these changes
Dec 2, 2023
Co-authored-by: Nic Klaassen <nic@goteleport.com>
timothyb89
approved these changes
Dec 5, 2023
Contributor
timothyb89
left a comment
timothyb89
left a comment
There was a problem hiding this comment.
This all seems very reasonable. I don't have much feedback to offer on the wrapper message discussion though.
public-teleport-github-review-bot
Bot
removed the request for review
from xacrimon
rosstimothy
approved these changes
Dec 6, 2023
|
@strideynet See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #33808
Based on guidance in the draft Resource Guidelines RFD: #34103
Introduces the protos for a Bot resource and a BotService that will provide CRUD for the Bot resource.
I've named the package
machineidv1and the serviceBotServicefairly intentionally - I'd like to introduce some other functionality at a future data (e.g tbot heartbeating / command and control) and I think it would be nice to have these defined within the same Proto package but implemented as other services. This lets us clearly mark which RPCs are expected be called by users and which should be called by tbot.