[v12] Continue completing uploads on not found errors#35104
Merged
zmb3 merged 1 commit intobranch/v12from Dec 1, 2023
Merged
Conversation
Prior to this change, if we failed to complete an upload, the completed would error out and stop processing uploads until the next interval (5 minutes later). This leads to us falling behind and allowing a large number of uncompleted uploads to accumulate, particularly when there are multiple auth servers attempting to complete the same set of uploads. Fixes gravitational/cloud#5938
github-actions
Bot
added
audit-log
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Collaborator
Author
|
Manual backport: cherry picked only the functionality change and skipped the tests since v12 has diverged too much. |
rosstimothy
approved these changes
Nov 28, 2023
Collaborator
Author
|
@Joerger PTAL |
Joerger
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, if we failed to complete an upload, the completed would error out and stop processing uploads until the next interval (5 minutes later). This leads to us falling behind and allowing a large number of uncompleted uploads to accumulate, particularly when there are multiple auth servers attempting to complete the same set of uploads.
Fixes gravitational/cloud#5938
Backports #35067
changelog: Allow Teleport to complete abandoned uploads faster in HA deployments.