Fix incorrect Kubernetes event watcher chunking#34981
Merged
Conversation
Improve handling of streaming events in response to non-chunked content-type from the Kubernetes API. Previously, when dealing with streaming events, the code streamed the response into the target connection. However, the Kubernetes API did not provide the content-type as chunked. This lack of information caused the forwarder to be unaware that the connection was chunked. Consequently, the forwarder delayed response writing by buffering it, intending to minimize the number of writes. In scenarios where the connection stream was busy with events, users might not receive individual events as chunks, leading to incomplete data. This could result in users receiving malformed JSON, triggering an abort of the process. To address this issue, this commit introduces a modification. After each event, the response is now flushed to ensure that users receive the event as a complete and well-formed chunk. This adjustment improves the reliability and integrity of the data received by users during streaming events. Fixes #34977 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
atburke
approved these changes
Nov 27, 2023
jakule
approved these changes
Nov 27, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve handling of streaming events in response to non-chunked content-type from the Kubernetes API.
Previously, when dealing with streaming events, the code streamed the response into the target connection. However, the Kubernetes API did not provide the content-type as chunked. This lack of information caused the forwarder to be unaware that the connection was chunked. Consequently, the forwarder delayed response writing by buffering it, intending to minimize the number of writes.
In scenarios where the connection stream was busy with events, users might not receive individual events as chunks, leading to incomplete data. This could result in users receiving malformed JSON, triggering an abort of the process.
To address this issue, this commit introduces a modification. After each event, the response is now flushed to ensure that users receive the event as a complete and well-formed chunk. This adjustment improves the reliability and integrity of the data received by users during streaming events.
Fixes #34977
Changelog: Improved streaming event handling for Kubernetes API by flushing response after each event, ensuring complete, well-formed chunks.