Fix installer to only use --azure-client-id if requested#34904
Merged
Fix installer to only use --azure-client-id if requested#34904
--azure-client-id if requested#34904Conversation
smallinsky
approved these changes
Nov 23, 2023
webvictim
approved these changes
Nov 24, 2023
Joerger
approved these changes
Nov 27, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the default installer to only use the
--azure-client-idflag to configure the node when an Azure client ID is present. This fixes a bug where the default installer from a v14 cluster would fail when trying to install a v13 node.Fixes #34860.
Changelog: Fixed error when installing a v13 node with the default installer from a v14 cluster