Fix yum config-manager invocation in installers and docs#34870
Fix yum config-manager invocation in installers and docs#34870
yum config-manager invocation in installers and docs#34870Conversation
github-actions
Bot
requested review from
fheinecke,
hugoShaka,
ptgott,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-gq1p8wl6q-goteleport.vercel.app/docs/ver/preview |
There was a problem hiding this comment.
This change not work on CentOS 7 out of the box. yum-config-manager needs to be installed on 8 forward, but works on all RHEL based distros. I would recommend adding a check for centos7, install yum-config-manager, or download and parse the repo config file manually.
|
Also, if this logic changes then this test must be updated as well. |
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@atburke Yeah, echoing @fheinecke's comment, sorry if the ticket description wasn't clear but this only affects AL2023, other distros should keep using existing command.
|
🤖 Vercel preview here: https://docs-h5rywo8gs-goteleport.vercel.app/docs/ver/preview |
|
Friendly ping @fheinecke |
fheinecke
left a comment
fheinecke
left a comment
There was a problem hiding this comment.
LGTM
This test step line should move to the next step as well, to capture the specifics of our install docs: https://github.com/gravitational/teleport.e/blob/master/.github/workflows/deploy-packages.yaml#L557-L558
public-teleport-github-review-bot
Bot
removed request for
xinding33 and
zmb3
…35023) * Fix yum config manager invocation * Install yum-utils instead
5 participants
This change fixes the invocation of the yum config manager in both the default installers and the docs.
Fixes #34538.
Changelog: Fixed default installer yum error on RHEL and Amazon Linux