Detect and report latency measurements for SSH sessions to the UI#34862
Merged
rosstimothy merged 1 commit intomasterfrom Dec 6, 2023
Merged
Detect and report latency measurements for SSH sessions to the UI#34862rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
rosstimothy
force-pushed
the
tross/latency
branch
4 times, most recently
from
85c2de0 to
370dcb6
Compare
avatus
reviewed
Nov 21, 2023
rosstimothy
force-pushed
the
tross/latency
branch
from
370dcb6 to
0f4e1ff
Compare
avatus
reviewed
Nov 22, 2023
rosstimothy
force-pushed
the
tross/latency
branch
7 times, most recently
from
63d884e to
bf2959f
Compare
avatus
approved these changes
Nov 28, 2023
ibeckermayer
approved these changes
Nov 29, 2023
rosstimothy
force-pushed
the
tross/latency
branch
2 times, most recently
from
db17b19 to
16873d2
Compare
Contributor
Author
|
@avatus @ibeckermayer I tweaked the frontend portion of this based on some feedback from the design team. Would you mind looking things over once more? I'm particularly interested to know if there is a better way to apply some of the css tweaks that I made. |
avatus
reviewed
Dec 4, 2023
Comment on lines
+79
to
+82
| if ( | ||
| (client >= warnThreshold || server >= warnThreshold) && | ||
| (client < warnThreshold || server < warnThreshold) | ||
| ) { |
Contributor
There was a problem hiding this comment.
This is fine but it seems like (correct me if I'm wrong) that the pattern is basically "show the highest threshold as the total". So if any are red, it'll be red, and if any are yellow, it'll show yellow.
I wonder if instead of doing these comparisons we could just do another small helper function like getColorForTotal and have the logic be
if either are red, return red
if either are yellow, return yellow
return green
thoughts?
Contributor
Author
There was a problem hiding this comment.
These were the rules that I was given from the design team regarding total color:
- green + green = green
- green + yellow = yellow
- green + red = red
- yellow + yellow = yellow
- yellow + red = red
- red + red = red
Initially the total color was solely based on the total latency, but that lead to the warning color being used for the total even though both legs of the connection were green. The feedback was this was confusing and somewhat alarming which resulted in the request to just stick with a green total color if both legs are ok.
Contributor
Author
There was a problem hiding this comment.
Simplified a bit in d688d2cd494a663f2652e1382cbad3d03af5ab09. WDYT?
avatus
approved these changes
Dec 4, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
small nit comment but css looks fine to me (i'm not a css person really so if it works it works)
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
fspmarshall
approved these changes
Dec 6, 2023
rosstimothy
force-pushed
the
tross/latency
branch
2 times, most recently
from
fae999f to
b5739d4
Compare
Monitors both the UI<->Proxy and Proxy<->SSH host connections in order to provide users with near real time latency data for ssh connections established via the UI. The client portion of the connection is measured by how long it takes to receive a web socket pong in response to sending a web socket ping. The host portion of the connection is measured by how long it takes to receive a reply of a keepalive@openssh.com global SSH request. The statistics are periodically sent via a new envelope type over the web socket where they are consumed and displayed to users.
rosstimothy
force-pushed
the
tross/latency
branch
from
b5739d4 to
e6d70d3
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Dec 7, 2023
…4862) Monitors both the UI<->Proxy and Proxy<->SSH host connections in order to provide users with near real time latency data for ssh connections established via the UI. The client portion of the connection is measured by how long it takes to receive a web socket pong in response to sending a web socket ping. The host portion of the connection is measured by how long it takes to receive a reply of a keepalive@openssh.com global SSH request. The statistics are periodically sent via a new envelope type over the web socket where they are consumed and displayed to users.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…4862) (#35516) Monitors both the UI<->Proxy and Proxy<->SSH host connections in order to provide users with near real time latency data for ssh connections established via the UI. The client portion of the connection is measured by how long it takes to receive a web socket pong in response to sending a web socket ping. The host portion of the connection is measured by how long it takes to receive a reply of a keepalive@openssh.com global SSH request. The statistics are periodically sent via a new envelope type over the web socket where they are consumed and displayed to users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monitors both the UI<->Proxy and Proxy<->SSH host connections in order to provide users with near real time latency data for ssh connections established via the UI. The client portion of the connection is measured by how long it takes to receive a web socket pong in response to sending a web socket ping. The host portion of the connection is measured by how long it takes to receive a reply of a keepalive@openssh.com global SSH request. The statistics are periodically sent via a new envelope type over the web socket where they are consumed and displayed to users.
Changelog: Calculate latency of Web SSH sessions and report it to users.