[v14] Emit events in CreateAuditStream for v13 clients#34793
Merged
atburke merged 3 commits intobranch/v14from Nov 20, 2023
Merged
[v14] Emit events in CreateAuditStream for v13 clients#34793atburke merged 3 commits intobranch/v14from
atburke merged 3 commits intobranch/v14from
Conversation
tigrato
approved these changes
Nov 20, 2023
rosstimothy
approved these changes
Nov 20, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from justinas
zmb3
added a commit
that referenced
this pull request
Nov 30, 2023
In #34793 we added a fix for missing audit events when v13 agents use sync recording modes against a v14 cluster. This fix missed a few events that used to be filtered out by TeeStreamer, and as a result we ended up writing session recording data for desktop and app sesions to the audit log. This data eventually caused a panic, likely due to an integer overflow.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
In #34793 we added a fix for missing audit events when v13 agents use sync recording modes against a v14 cluster. This fix missed a few events that used to be filtered out by TeeStreamer, and as a result we ended up writing session recording data for desktop and app sesions to the audit log. This data eventually caused a panic, likely due to an integer overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #34667 to branch/v14
Changelog: Fixed auth server not emitting session events for v13 clients