chore: Use mkwinsyscall in lib/auth/webauthnwin#34737
Merged
codingllama merged 10 commits intomasterfrom Nov 21, 2023
Merged
Conversation
codingllama
added
backport/branch/v12
no-changelog
Contributor
Author
|
CC Zac and Noah as the resident Windows experts. |
Contributor
Author
|
This took a lot more effort than it looks :/ Tested on Windows using |
strideynet
reviewed
Nov 21, 2023
codingllama
force-pushed
the
codingllama/dt-win-mkwinsyscall
branch
from
7283214 to
b7697a4
Compare
tigrato
approved these changes
Nov 21, 2023
public-teleport-github-review-bot
Bot
removed request for
gabrielcorado,
kimlisa and
zmb3
ravicious
approved these changes
Nov 21, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I compiled it on my Windows VM and ran tsh webauthnwin diag as well, using my regular key through Parallels.
Contributor
Author
|
Thanks for trying it out, Rafał! |
|
@codingllama See the table below for backport results.
|
This was referenced Nov 21, 2023
codingllama
commented
Jan 18, 2024
Comment on lines
-231
to
-233
| if err := modWebAuthn.Load(); err != nil { | ||
| return 0, err | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Note: removing the explicit load was the cause of #36851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mkwinsyscall to generate the Windows boilerplate in lib/auth/webauthnwin.
Closes #31559.