web: use desktop name instead of addr in audit event summary#34652
Merged
web: use desktop name instead of addr in audit event summary#34652
Conversation
zmb3
force-pushed
the
zmb3/web-desktop-audit-events
branch
from
5f9987f to
5116805
Compare
gzdunek
approved these changes
Nov 17, 2023
| style="word-break: break-word;" | ||
| > | ||
| User [joe] was denied access to Windows desktop [Administrator@100.104.52.89:3389] on [desktopaccess.com] | ||
| User [joe] was denied access to Windows desktop [Administrator@undefined] on [desktopaccess.com] |
Contributor
There was a problem hiding this comment.
Can we add desktop_name to these events in the story? undefined doesn't look too good 🙈
ryanclark
approved these changes
Nov 21, 2023
This was referenced Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34392
Changelog: use the desktop name instead of address in the audit log view.