[v14] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.46.0#34562
Closed
jentfoo wants to merge 5 commits intobranch/v14from
Closed
[v14] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.46.0#34562jentfoo wants to merge 5 commits intobranch/v14from
jentfoo wants to merge 5 commits intobranch/v14from
Conversation
…pc/otelgrpc Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.42.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.42.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…pc/otelgrpc Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.42.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.42.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
jentfoo
added
go
rosstimothy
reviewed
Nov 13, 2023
Comment on lines
19
to
21
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | ||
| go.opentelemetry.io/otel/sdk v1.19.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | |
| go.opentelemetry.io/otel/sdk v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 | |
| go.opentelemetry.io/otel/sdk v1.20.0 |
Contributor
Author
There was a problem hiding this comment.
I am not sure how I can update these. Doing this update results in the following ambiguous import error:
github.com/gravitational/teleport/api/client imports
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
google.golang.org/grpc/interop imports
golang.org/x/oauth2/google imports
cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
cloud.google.com/go v0.34.0 (/home/mjensen/go/pkg/mod/cloud.google.com/go@v0.34.0/compute/metadata)
cloud.google.com/go/compute/metadata v0.2.3 (/home/mjensen/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.2.3)
If I specify the metadata version in the go.mod it corrects this error, but if a go mod tidy is ran the manually specified metadata is removed and the error will return.
@rosstimothy or @codingllama is this something you have encountered before?
Contributor
There was a problem hiding this comment.
$ cd api
$ go get cloud.google.com/go/compute/metadata@v0.34.0
$ go mod tidy
Contributor
Author
There was a problem hiding this comment.
Unfortunately this runs into the same issue I am running into. The following commands will complete successfully, however the go mod tidy will remove the added record and subsequent go mod tidy's (or builds) will fail.
rosstimothy
reviewed
Nov 15, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Updates to go.mod look good to me but the linter is complaining about a few additional places that we are using the deprecated interceptors.
codingllama
approved these changes
Nov 16, 2023
Contributor
|
Superseded by #34803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v14 update of
otelgrpcto address CVE-2023-47108. Examples were updated in #34536