Skip to content

Web: Fix access lists overdue dates notification notes#34542

Merged
kimlisa merged 4 commits intomasterfrom
lisa/fix-review-bug
Nov 13, 2023
Merged

Web: Fix access lists overdue dates notification notes#34542
kimlisa merged 4 commits intomasterfrom
lisa/fix-review-bug

Conversation

@kimlisa
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa commented Nov 13, 2023

Overdue dates were incorrectly rendered as due later than it is supposed to.

If due date was 10/19/2023 from today, that's overdue 25 days

before:

image

fixed:

image

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@kimlisa kimlisa force-pushed the lisa/fix-review-bug branch from c8db09d to cd42af8 Compare November 13, 2023 17:53
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@kimlisa kimlisa added the no-changelog Indicates that a PR does not require a changelog entry label Nov 13, 2023
@kimlisa kimlisa force-pushed the lisa/fix-review-bug branch from dc41418 to ed3f2c1 Compare November 13, 2023 18:32
@kimlisa kimlisa enabled auto-merge November 13, 2023 18:32
@kimlisa kimlisa added this pull request to the merge queue Nov 13, 2023
Merged via the queue into master with commit b60dcc2 Nov 13, 2023
@kimlisa kimlisa deleted the lisa/fix-review-bug branch November 13, 2023 19:09
@public-teleport-github-review-bot
Copy link
Copy Markdown

@kimlisa See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/md ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants