Skip to content

Update fido2.go with more user focused error message#34529

Merged
pschisa merged 2 commits intomasterfrom
pschisa-patch-6
Nov 14, 2023
Merged

Update fido2.go with more user focused error message#34529
pschisa merged 2 commits intomasterfrom
pschisa-patch-6

Conversation

@pschisa
Copy link
Copy Markdown
Contributor

@pschisa pschisa commented Nov 13, 2023

Adding the fact that attempting to use passwordless is what prevents the hardware key from being registered when not supported. Multiple customers have encountered this error and did not know it could be circumvented by setting the passwordless option to No.

changelog: Improve the error message when attempting to enroll a hardware key that cannot support passwordless.

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@pschisa pschisa added the no-changelog Indicates that a PR does not require a changelog entry label Nov 13, 2023
@pschisa pschisa enabled auto-merge November 13, 2023 15:40
@zmb3 zmb3 requested a review from codingllama November 13, 2023 16:57
Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!

I suggest adding a Changelog line to the PR description (and dropping the no-changelog label), this seems worth mentioning. I've added a backport for v12 as well.

@pschisa pschisa removed the no-changelog Indicates that a PR does not require a changelog entry label Nov 13, 2023
@pschisa pschisa added this pull request to the merge queue Nov 14, 2023
Merged via the queue into master with commit 7135486 Nov 14, 2023
@pschisa pschisa deleted the pschisa-patch-6 branch November 14, 2023 19:17
@public-teleport-github-review-bot
Copy link
Copy Markdown

@pschisa See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants