Support ClusterNetworkingConfig and AuthPreference in --apply-on-startup#34524
Merged
Support ClusterNetworkingConfig and AuthPreference in --apply-on-startup#34524
Conversation
lxea
added
backport/branch/v14
no-changelog
r0mant
approved these changes
Nov 13, 2023
hugoShaka
reviewed
Nov 13, 2023
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Could you add the kinds to the ResourceApplyPriority map above? This will also dynamically update the CLI help strings. I think the docs CLI reference needs to be manually edited.
Could you also add a couple cases to the existing tests in init_test.go?
Contributor
|
🤖 Vercel preview here: https://docs-i199aj8ae-goteleport.vercel.app/docs/ver/preview |
hugoShaka
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/gravitational/cloud/pull/6204