Skip to content

Allow user locks to affect access list membership.#34354

Merged
mdwn merged 3 commits intomasterfrom
mike.wilson/locking-affects-access-lists
Nov 15, 2023
Merged

Allow user locks to affect access list membership.#34354
mdwn merged 3 commits intomasterfrom
mike.wilson/locking-affects-access-lists

Conversation

@mdwn
Copy link
Copy Markdown
Contributor

@mdwn mdwn commented Nov 8, 2023

Access list membership will now be impacted by active user locks. If a user is locked, they will not be considered a part of an access list. This, in turn will be used for things like Okta assignments to ensure that Okta access can be rescinded while a lock is active.

changelog: Access lists now respect user locking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions Bot requested review from Joerger and avatus November 8, 2023 20:30
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles the case where the user lock exists when you run IsAccessListMember, but what about if the lock is added after the fact? Usually we use some sort of watcher to detect that.

Comment thread lib/services/access_list_test.go Outdated
Comment thread lib/services/access_list.go Outdated
@mdwn
Copy link
Copy Markdown
Contributor Author

mdwn commented Nov 8, 2023

This handles the case where the user lock exists when you run IsAccessListMember, but what about if the lock is added after the fact? Usually we use some sort of watcher to detect that.

The watcher is in https://github.com/gravitational/teleport.e/pull/2605, which will need to be expanded to look after locks once this is implemented.

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Nov 8, 2023

I'd consider changing the title of this too. When I first read it, I thought you were going to allow locking an access list (a la tctl lock --access-list foo), but this is just extending what user locks do, not adding a new lock target.

@mdwn mdwn changed the title Allow locks to deny access to access lists. Allow user locks to affect access list membership. Nov 9, 2023
Copy link
Copy Markdown
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. Generally when I review the frontend changes I'm only able to use Storybook. Do i need a special license to run access lists locally or can I just setup my cluster with some new rules/whatever. My admin doesn't seem to have privileges to create anything

@mdwn
Copy link
Copy Markdown
Contributor Author

mdwn commented Nov 10, 2023

Code looks fine to me. Generally when I review the frontend changes I'm only able to use Storybook. Do i need a special license to run access lists locally or can I just setup my cluster with some new rules/whatever. My admin doesn't seem to have privileges to create anything

It should just require an enterprise license.

Mike Wilson added 3 commits November 13, 2023 11:45
Access list membership will now be impacted by active user locks. If a user
is locked, they will not be considered a part of an access list. This, in turn
will be used for things like Okta assignments to ensure that Okta access can be
rescinded while a lock is active.
@mdwn mdwn force-pushed the mike.wilson/locking-affects-access-lists branch from 435ef67 to dc3aab5 Compare November 13, 2023 16:46
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from Joerger November 15, 2023 15:21
@mdwn mdwn added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit 590435c Nov 15, 2023
@mdwn mdwn deleted the mike.wilson/locking-affects-access-lists branch November 15, 2023 15:46
@public-teleport-github-review-bot
Copy link
Copy Markdown

@mdwn See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants