Skip to content

Fix default piv key slot to match comments and docs#34350

Merged
Joerger merged 1 commit intomasterfrom
joerger/fix-default-piv-slot-mixup
Nov 9, 2023
Merged

Fix default piv key slot to match comments and docs#34350
Joerger merged 1 commit intomasterfrom
joerger/fix-default-piv-slot-mixup

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Nov 8, 2023 •
edited
Loading

I mixed up the order because they are out of order in the piv-go library

        SlotAuthentication     = Slot{0x9a, 0x5fc105}
        SlotSignature          = Slot{0x9c, 0x5fc10a}
        SlotCardAuthentication = Slot{0x9e, 0x5fc101}
        SlotKeyManagement      = Slot{0x9d, 0x5fc10b}

I updated the comments/docs to match the released functionality.

@github-actions github-actions Bot requested review from Tener and codingllama November 8, 2023 19:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Nov 8, 2023
codingllama
codingllama approved these changes Nov 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this already released? Any backward compatibility concerns?

@Tener
Copy link
Copy Markdown
Contributor

Tener commented Nov 9, 2023

Was this already released? Any backward compatibility concerns?

Same.

If this was released then perhaps some devices would need to be re-enrolled post this change?

@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Nov 9, 2023

Was this already released? Any backward compatibility concerns?

Only very minor concerns, mostly one-off UX issues. However, I suppose the better course of action here is to invert the docs/comments instead of the functionality. Updating now.

@Joerger Joerger force-pushed the joerger/fix-default-piv-slot-mixup branch 2 times, most recently from 3a2e2cf to b31a360 Compare November 9, 2023 17:55
@Joerger Joerger force-pushed the joerger/fix-default-piv-slot-mixup branch from b31a360 to d70d23b Compare November 9, 2023 17:55
@Joerger Joerger requested review from ptgott and zmb3 November 9, 2023 17:59
@Joerger Joerger changed the title Fix default piv key slot to match comment/docs Fix default piv key slot to match comments and docs Nov 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

🤖 Vercel preview here: https://docs-8v58lrwha-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from zmb3 November 9, 2023 18:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

🤖 Vercel preview here: https://docs-rmsdga8rj-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

🤖 Vercel preview here: https://docs-27svy6zxt-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

🤖 Vercel preview here: https://docs-etoz7brjs-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit 9c70432 Nov 9, 2023
@Joerger Joerger deleted the joerger/fix-default-piv-slot-mixup branch November 9, 2023 18:34
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Nov 9, 2023

@Joerger See the table below for backport results.

Branch Result
branch/v14 Create PR

@Joerger Joerger mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tener Tener Tener approved these changes

@codingllama codingllama codingllama approved these changes

@ptgott ptgott ptgott approved these changes

Assignees

No one assigned

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joerger @Tener @codingllama @ptgott