Machine ID on Kubernetes: Use name instead of secret_name for kubernetes_secret destination type#34303
Closed
tuladhar wants to merge 2 commits intogravitational:masterfrom
tuladhar:patch-1
Closed
Machine ID on Kubernetes: Use name instead of secret_name for kubernetes_secret destination type#34303tuladhar wants to merge 2 commits intogravitational:masterfrom tuladhar:patch-1
name instead of secret_name for kubernetes_secret destination type#34303tuladhar wants to merge 2 commits intogravitational:masterfrom
tuladhar:patch-1
Conversation
tuladhar
changed the title
name instead of secret_name for kubernetes_secret destination typename instead of secret_name for kubernetes_secret destination type
tuladhar
changed the title
name instead of secret_name for kubernetes_secret destination typename instead of secret_name for kubernetes_secret destination type
strideynet
approved these changes
Nov 8, 2023
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Great catch - thank you
Contributor
|
@tuladhar Thanks for this PR! We'll be opening a buddy PR with your commit so we can get it through CI/CD. |
Merged
Collaborator
|
Merged in #34430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the documentation here,
nameshould be used notsecret_namefortype: kubernetes_secret