[v13] Filter dangerous environment variables before reexec#34275
Merged
jentfoo merged 1 commit intobranch/v13from Nov 7, 2023
Merged
[v13] Filter dangerous environment variables before reexec#34275jentfoo merged 1 commit intobranch/v13from
jentfoo merged 1 commit intobranch/v13from
Conversation
* Filter dangerous environment variables before reexec This change filters potentially dangerous environment variables that could result in code execution. This seemed safest to integrate as a new struct within the `environment.go` in utils. This struct allows us to validate variables as they are built, making sure that regardless of the source we have validated them against our filter list. The environment specific logic was significant enough that the current and new logic was refactored into a new package `envutils`. * Allow the easy addition of execution environment into SafeEnv In addition this commit adds in a check to look for duplicate keys which may be attempting to overload our set values. * Apply PR Feedback and remove env duplicate handling * Apply additional PR feedback
rosstimothy
approved these changes
Nov 7, 2023
codingllama
approved these changes
Nov 7, 2023
public-teleport-github-review-bot
Bot
removed request for
r0mant and
reedloden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #34177 to branch/v13