Update repo for Windows artifact build pipeline GHA migration#34273
Merged
Update repo for Windows artifact build pipeline GHA migration#34273
Conversation
fheinecke
added
the
no-changelog
fheinecke
force-pushed
the
fred/windows-build-updates-1
branch
from
98ac3f6 to
a02b98e
Compare
Contributor
Author
|
Added do-not-merge label until the pending teleport.e PR is merged, and the e ref is updated in this PR |
Contributor
|
I don't know enough about our build pipelines to provide a meaningful review |
camscale
approved these changes
Nov 7, 2023
Contributor
camscale
left a comment
camscale
left a comment
There was a problem hiding this comment.
Looks good. Pretty standard stuff in my experience changing the pipelines over to GHA.
The powershell also seems fine, but I have little experience to know if there might be better ways to be doing things or if there are subtle bugs. But it is quite readable and looks straightforward enough.
tcsc
approved these changes
Nov 8, 2023
tigrato
approved these changes
Nov 8, 2023
r0mant
approved these changes
Nov 8, 2023
fheinecke
removed
do-not-merge
no-changelog
|
@fheinecke See the table below for backport results.
|
fheinecke
added a commit
that referenced
this pull request
Nov 9, 2023
fheinecke
added a commit
that referenced
this pull request
Nov 9, 2023
fheinecke
added a commit
that referenced
this pull request
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes several changes, all required for moving the Windows build pipeline to GHA:
eref [PENDINGteleport.ePR]The actual Windows build workflows in theThis is now available here.teleport.erepo are not quite ready for review, however they are very close and these changes are stable enough that I'd like to open this up for review.Reviewers, we (Gravitational) have a week (total) to merge and backport this and at least two other PRs, test them all together, and cut at least one new full release. If all this is not completed by then, then we lose the ability to cut new releases. Please review this as soon as possible so that I can get fixes in quickly.
Changelog: Updated the code signing certificate for Windows artifacts