Store original roles with user login state.#34257
Merged
Conversation
The user's original static roles are now stored along with the user login state. This is necessary to properly recalculate user access on access list membership change, as SSO users will expire after 24 hours, making it impossible to refer to the original user definition to determine the new role membership for the user.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mdwn
added
the
no-changelog
Collaborator
|
Any concerns with backwards compatibility here? (Doesn't look like it, though a subsequent PR probably needs to be careful to handle the case where one of the original roles no longer exists..) |
Contributor
Author
No, but totally agreed. I'll need to ensure that the consumers of this look after this situation carefully. |
zmb3
approved these changes
Nov 6, 2023
tigrato
approved these changes
Nov 8, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
This was referenced Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user's original static roles are now stored along with the user login state. This is necessary to properly recalculate user access on access list membership change, as SSO users will expire after 24 hours, making it impossible to refer to the original user definition to determine the new role membership for the user.