Skip to content

Temporarily disable conditional updates for users#34255

Merged
rosstimothy merged 1 commit intomasterfrom
tross/temporarily_disable_user_conditional_updates
Nov 6, 2023
Merged

Temporarily disable conditional updates for users#34255
rosstimothy merged 1 commit intomasterfrom
tross/temporarily_disable_user_conditional_updates

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

The operator is not handling revisions which causes TestUsersUpdate in users_controller_test.go to fail. Rolling back the user service backend to use update until the operator is updated to unblock CI.

@rosstimothy rosstimothy force-pushed the tross/temporarily_disable_user_conditional_updates branch from e221f04 to 81e9de8 Compare November 6, 2023 16:53
@rosstimothy rosstimothy marked this pull request as ready for review November 6, 2023 16:54
@rosstimothy rosstimothy requested review from hugoShaka and zmb3 November 6, 2023 16:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions Bot added size/sm tctl tctl - Teleport admin tool labels Nov 6, 2023
@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Nov 6, 2023
The operator is not handling revisions which causes TestUsersUpdate
in users_controller_test.go to fail. Rolling back the user service
backend to use update until the operator is updated to unblock CI.
@rosstimothy rosstimothy force-pushed the tross/temporarily_disable_user_conditional_updates branch from 81e9de8 to 4e27ef2 Compare November 6, 2023 17:38
@rosstimothy rosstimothy enabled auto-merge November 6, 2023 17:43
@rosstimothy rosstimothy added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit 83bc454 Nov 6, 2023
@rosstimothy rosstimothy deleted the tross/temporarily_disable_user_conditional_updates branch November 6, 2023 18:36
rosstimothy added a commit that referenced this pull request Nov 7, 2023
#34255 temporarily
reverted users to blind update since the operator didn't handle
revisions properly. Now that #34265
has been merged to update the operator to support revisions, the
conditional updates for users can be restored.
github-merge-queue Bot pushed a commit that referenced this pull request Nov 7, 2023
#34255 temporarily
reverted users to blind update since the operator didn't handle
revisions properly. Now that #34265
has been merged to update the operator to support revisions, the
conditional updates for users can be restored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants