Skip to content

Fix Machine ID selection of Kubernetes Access address/port#34202

Merged
strideynet merged 9 commits intomasterfrom
strideynet/fix-tbot-kube-port
Nov 6, 2023
Merged

Fix Machine ID selection of Kubernetes Access address/port#34202
strideynet merged 9 commits intomasterfrom
strideynet/fix-tbot-kube-port

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

@strideynet strideynet commented Nov 3, 2023

Closes #19811 / Semi-closes #34178

Addresses a few long standing issues w/ the selection of what address to use when tbot generates the kubeconfig file. This also feels a bit neater/more explicit than the previous code and I've also included more tests to cover this process since there's a few edgecases.

changelog: Fixes issue where tbot would select the wrong address for Kubernetes Access when in ports separate mode.

@strideynet strideynet requested a review from tigrato November 3, 2023 13:42
@strideynet
Copy link
Copy Markdown
Contributor Author

strideynet commented Nov 3, 2023

Backport will exclude the docs changes (b23d53a) and a separate PR will be raised when this change is released to include a note specifying the version this is fixed within.

@strideynet strideynet marked this pull request as ready for review November 3, 2023 13:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023

🤖 Vercel preview here: https://docs-2bzf99jy2-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023

🤖 Vercel preview here: https://docs-owf6bnt78-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 approved these changes Nov 3, 2023
View reviewed changes
Comment thread lib/tbot/config/template_kubernetes.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023

🤖 Vercel preview here: https://docs-o3nc1dalo-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023

🤖 Vercel preview here: https://docs-i5nvhxbnr-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023

🤖 Vercel preview here: https://docs-76tjusnok-goteleport.vercel.app/docs/ver/preview

@strideynet strideynet enabled auto-merge November 6, 2023 18:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2023

🤖 Vercel preview here: https://docs-5bwebroa4-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2023

🤖 Vercel preview here: https://docs-4euiyivz1-goteleport.vercel.app/docs/ver/preview

@strideynet strideynet disabled auto-merge November 6, 2023 20:31
@strideynet strideynet added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit 9157b85 Nov 6, 2023
@strideynet strideynet deleted the strideynet/fix-tbot-kube-port branch November 6, 2023 20:52
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Nov 6, 2023

@strideynet See the table below for backport results.

Branch Result
branch/v14 Create PR

@strideynet strideynet mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrato tigrato tigrato approved these changes

@zmb3 zmb3 zmb3 approved these changes

@ptgott ptgott ptgott approved these changes

Assignees

No one assigned

Labels

documentation machine-id size/sm

Projects

None yet

Milestone

No milestone

4 participants

@strideynet @tigrato @zmb3 @ptgott